Mono build prob­lems on FreeBSD-current

I try to build mono on FreeB­SD-cur­rent (it is a depen­den­cy of some GNOME pro­gram). Unfor­tu­nate­ly this does not work cor­rect­ly.

What I see are hangs of the build. If I stop the build when it hangs and restart it, it will con­tin­ue and suc­ceed to process the build steps a lit­tle bit fur­ther, but then it hangs again.

If I ktrace the hang­ing process, I see that there is a call to wait return­ing with the error mes­sage that the child does not exist. Then there is a call to nanosleep.

It looks to me like this process missed some SIGCLD (or is wait­ing for some­thing which did not exist at all), and a loop is wait­ing for a child to exit. This loop prob­a­bly has no prop­er con­di­tion for the fact that there is no such child (any­more). As such it will stay for­ev­er in this loop.

So I grepped a litte bit around in mono and found the fol­low­ing code in <mono-src-dir>/mcs/class/Mono.Posix/Mono.Unix/UnixProcess.cs:

public void WaitForExit ()
{
    int status;
    int r;
    do {
        r = Native.Syscall.waitpid (pid, out status, (Native.WaitOptions) 0);
    } while (UnixMarshal.ShouldRetrySyscall (r));
    UnixMarshal.ThrowExceptionForLastErrorIf (r);
}

This does look a lit­tle bit as it could be relat­ed to the prob­lem I see, but Shoul­dRetrySyscall only returns true if the errno is EINTR. So this looks cor­rect. 🙁

I looked a lit­tle bit more at this file and it looks like either I do not under­stand the seman­tic of this lan­guage, or Get­ProcessSta­tus does return the return­val­ue of the wait­pid call instead of the sta­tus (which is not what it shall return to my under­stand­ing). If I am cor­rect, it can not real­ly detect the sta­tus of a process. It would be very bad if such a fun­da­men­tal thing went unno­ticed in mono…  which does not put a good light on the unit-tests (if any) or the gen­er­al test­ing of mono. For this rea­son I hope I am wrong.

I did not stop there, as this part does not look like it is the prob­lem. I found the fol­low­ing in mono/io-layer/processes.c:

static gboolean waitfor_pid (gpointer test, gpointer user_data)
{
...
    do {
        ret = waitpid (process->id, &status, WNOHANG);
    } while (errno == EINTR);

if (ret <= 0) { /* Process not ready for wait */ #ifdef DEBUG g_message ("%s: Process %d not ready for waiting for: %s", __func__, process->id, g_strerror (errno)); #endif

return (FALSE); }

#ifdef DEBUG g_message ("%s: Process %d finished", __func__, ret); #endif

process->waited = TRUE; ... }

And here we have the prob­lem, I think. I changed the (ret <= 0) to  (ret == 0 || (ret < 0 && errno != ECHILD)). This will not real­ly give the cor­rect sta­tus, but at least it should not block any­more and I should be able to see the dif­fer­ence dur­ing the build.

And now after test­ing, I see a dif­fer­ence, but the prob­lem is still there. The wait with ECHILD is gone in the loop, but there is still some loop with a sem­a­phore oper­a­tion:

62960 mono     CALL  clock_gettime(0xd,0xbf9feef8)
62960 mono     RET   clock_gettime 0
62960 mono     CALL  semop(0x20c0000,0xbf9feef6,0x1)
62960 mono     RET   semop 0
62960 mono     CALL  semop(0x20c0000,0xbf9feef6,0x1)
62960 mono     RET   semop 0
62960 mono     CALL  semop(0x20c0000,0xbf9feef6,0x1)
62960 mono     RET   semop 0
62960 mono     CALL  semop(0x20c0000,0xbf9feef6,0x1)
62960 mono     RET   semop 0
62960 mono     CALL  nanosleep(0xbf9fef84,0)
62960 mono     RET   nanosleep 0
62960 mono     CALL  clock_gettime(0xd,0xbf9feef8)
62960 mono     RET   clock_gettime 0
62960 mono     CALL  semop(0x20c0000,0xbf9feef6,0x1)
62960 mono     RET   semop 0
62960 mono     CALL  semop(0x20c0000,0xbf9feef6,0x1)
62960 mono     RET   semop 0
62960 mono     CALL  semop(0x20c0000,0xbf9feef6,0x1)
62960 mono     RET   semop 0
62960 mono     CALL  semop(0x20c0000,0xbf9feef6,0x1)
62960 mono     RET   semop 0
62960 mono     CALL  nanosleep(0xbf9fef84,0)

OK, there is more going on. I think some­one with more knowl­edge about mono should have a look at this (do not only look at this semop thing, but also look why it los­es a child).

Send to Kin­dle

3 thoughts on “Mono build prob­lems on FreeBSD-current”

  1. Pingback: Tweets that mention Mono build prob­lems on FreeBSD-current | Alexander Leidinger -- Topsy.com
  2. Hum

    I am afraid you are right and the code in UnixProcess.cs is wrong… May I sug­gest you to open a bug for this in the Nov­el­l’s bug track­er?
    https://bugzilla.novell.com

    Regard­ing the prob­lem glob­al­ly:

    I also did local edits in my svn check­out to com­pile mono with debug­ging sup­port but unfor­tu­nate­ly race con­di­tions occurs real­ly less often then and debug­ging is just hard­er… So I have not pushed any of these patch­es in the FreeB­SD port. I had almost the same prob­lem that was trig­gered by run­ning mono‑2.6 (not yet in the ports) and your patch to processes.c seems to solve it too. You can have a look at the bug report at nov­ell here:
    https://bugzilla.novell.com/show_bug.cgi?id=528830

    More test­ing is need­ed but I think you put your fin­ger at the right loca­tion, I have been fooled by the way I dis­cov­ered the prob­lem and though it was a regres­sion… Maybe it’s not actu­aly.

    Which ver­sion of mono are you run­ning ?

    Maybe chat­ting about all this on mono@ is the best place?

    Thanks,
    Romain

  3. Pingback: Debugging lang/mono — 2nd round « The Daily BSD

Leave a Reply

This site uses Akismet to reduce spam. Learn how your comment data is processed.